fix(runtime-core): reactive children with teleport #2873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Jan 11, 2021
| target.value = targetB | ||
| await nextTick() | ||
| } catch (err) { | ||
| expect(err).toBeUndefined() |
There was a problem hiding this comment.
why not remove the try catch altogether, I don't think it makes sense for this code to throw an undefined error
There was a problem hiding this comment.
Yeah, it looks a little weird. I'm just trying to show you that an error is thrown when you excute this test case before fixing it.
Actually, I wanted to refactor the test cases after you merged my PRs. Because this one can be tested together with the test case of "should update target" that I modified in my other PR.
There was a problem hiding this comment.
@leaon4 I'm not sure what other PR you are referring to, can you clarify?
There was a problem hiding this comment.
HcySunYang
added
the
🔨 p3-minor-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see test case