Skip to content

chore(types): export UnwrapNestedRefs type #4223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

webfansplz
Copy link
Member

export UnwrapNestedRefs type for use by third-party libraries that need to use this type, such as vue-demi.

Reason

The purpose of this is to fix vueuse issue #648

@webfansplz
Copy link
Member Author

Hi @posva , May I ask the progress of this PR?

@posva
Copy link
Member

posva commented Aug 9, 2021

What is this for? It's linking a closed issue

@webfansplz
Copy link
Member Author

webfansplz commented Aug 9, 2021

The issue was closed because the vuejs/composition-api fix it, but it also need the support of Vue3

In simple terms,There are some usage scenarios that require the UnwrapNestedRefs type when export * from 'vue', such as vue-demi.

@posva @antfu

@edison1105 edison1105 requested a review from antfu August 9, 2021 12:06
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to expose the type (currently in VueUse we copied the type to make it work)

@webfansplz
Copy link
Member Author

Hi. @yyx990803 maybe this can merged 😊

@yyx990803
Copy link
Member

Already exported in 2b588cf

@yyx990803 yyx990803 closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createGlobalState type declaration error
4 participants