Skip to content

build(deps-dev): bump typescript from 4.3.5 to 4.4.2 #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2021

Bumps typescript from 4.3.5 to 4.4.2.

Release notes

Sourced from typescript's releases.

TypeScript 4.4.2

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.4 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 4.4 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 1, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-4.4.2 branch from edea1ee to c702f87 Compare September 1, 2021 20:39
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.3.5 to 4.4.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.3.5...v4.4.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-4.4.2 branch from c702f87 to 7d6792a Compare September 1, 2021 20:40
@yyx990803
Copy link
Member

Looks like TS 4.4 breaks the build in two ways:

  1. Caught errors are now unknown - this can be ignored by setting "useUnknownInCatchVariables": false in tsconfig.json

  2. The type inference for h + return type of defineComponent seems to be broken. Spent some time looking into it but don't have a clear clue yet. /cc @pikax

@yyx990803
Copy link
Member

Ok the h type inference issue is that now if the defineComponent call doesn't explicitly declare emits option, then h won't accept arbitrary onXXX handlers. Should be related to the emits to handler props inference PR (#3926) - /cc @Amour1688

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Size report

Path Size
vue.global.prod.js 45.81 KB (0%)
runtime-dom.global.prod.js 30.22 KB (0%)
size-check.global.prod.js 17.42 KB (0%)

@pikax
Copy link
Member

pikax commented Sep 2, 2021

@yyx990803 fixed the issues with h the reason why it wasn't accepting an arbitrary onXXX was because the onXXX was having a type of undefined instead of function

I used catch(e :any) because the option useUnknownInCatchVariables was failing the api-extractor on test-dts.

What's missing now is fixing the tests which relied on namespaceURI which was removed

@yyx990803
Copy link
Member

namesapceURI test cases can simply be fixed via (node as Element).namespaceURI for now

@yyx990803 yyx990803 merged commit 305883a into master Sep 2, 2021
@yyx990803 yyx990803 deleted the dependabot/npm_and_yarn/typescript-4.4.2 branch September 2, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants