Skip to content

fix: fix transition-group processing of whitespace nodes #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: fix transition-group processing of whitespace nodes #4647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/runtime-core/src/components/BaseTransition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
cloneVNode,
Comment,
isSameVNodeType,
Text,
VNode,
VNodeArrayChildren,
Fragment
Expand Down Expand Up @@ -470,7 +471,8 @@ export function getTransitionRawChildren(
)
}
// comment placeholders should be skipped, e.g. v-if
else if (keepComment || child.type !== Comment) {
// #4621, #4622, #4637 also skip text nodes
else if ((keepComment || child.type !== Comment) && child.type !== Text) {
Copy link
Member

@edison1105 edison1105 Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a correct fix and will even cause the following code not to render foo correctly.

<transition-group>
  foo
</transition-group>

We can't filter its raw children, we should filter the rendered children

ret.push(child)
}
}
Expand Down