chore(@vue/shared): add "sideEffects": false
#5480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, all the code in this package is side-effects-free.
Without the
sideEffects
flag, bundlers rely on code analysis andthe
/*#__PURE__*/
comments for tree-shaking.As bundlers' implementations vary, the analysic may or may not be
exhaustive.
For example, a file that contains only the following line of code:
If bundled by esbuild (
esbuild --bundle test.js --tree-shaking=true
),the output would be tens of lines.
(Technically, it's not esbuild's bug, because
Object.freeze
can be overwritten,Array.isArray
could be overwritten to a getter,+
can have side effects… Even though we know they are side-effects-free, it would require much more work from us to make bundlers happy)After this PR, the output will be an empty IIFE.
Credit to @hardfist for discovering this issue.