fix(suspense): warn when using asnyc setup when not inside a Supsense boundary. (fix: #3659) #5565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… boundary. Prior Art by https://github.com/HcySunYang in #3657 refactor: move warn code to more suitable location
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LinusBorg
added
🔨 p3-minor-bug
|
Note: I noticed that there's a closed PR from @HcySunYang that basically does the same thing - can we just reopen that one? I would not mind. Not sure what the proper etiquette is for this case. |
edison1105
approved these changes
Mar 11, 2022
HcySunYang
approved these changes
Mar 11, 2022
|
@LinusBorg Just use this PR, it's okay, great job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should warn users when they are using asnyc setup in a component that is not inside a Supsense boundary, because that component will now be stuck and never render.
Prior Art by https://github.com/HcySunYang in #3657
close #3649