chore: lint on ci and lint test files #5727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I introduced lint to CI in 1414f17 before seeing this PR - I grouped it with dts tests to reduce the parallel run since even with both combined they are faster than the main test suite. The lockfile also has a bunch of conflicts now, could we rebase this? |
|
@yyx990803 The PR is rebased and only kept the relevant changes: add linting for test files and ensure that we don't let focused tests slip through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a linting job on CI to catch regressions.
A few lint issues have been fixed in the process (one lint rule has been removed as the restriction no longer applies, see 7efb9db).
The test files are now also processed, and rules have been added to avoid letting focused or disabled tests slip through.
This has been discussed after #5715