-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
build(deps-dev): bump typescript to 4.7.4 #6215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -814,6 +814,7 @@ export function finishComponentSetup( | |
// pass runtime compat config into the compiler | ||
finalCompilerOptions.compatConfig = Object.create(globalCompatConfig) | ||
if (Component.compatConfig) { | ||
// @ts-expect-error types are not compatible | ||
extend(finalCompilerOptions.compatConfig, Component.compatConfig) | ||
Comment on lines
+817
to
818
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've checked the types and they are different, we could possible update the |
||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,14 +128,14 @@ function testRender(type: string, render: typeof renderToString) { | |
await render( | ||
createApp( | ||
defineComponent({ | ||
extends: { | ||
extends: defineComponent({ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typescript has hard type inferring component options, I believe we should always enforce the usage of |
||
data() { | ||
return { msg: 'hello' } | ||
}, | ||
render(this: any) { | ||
render() { | ||
return h('div', this.msg) | ||
} | ||
} | ||
}) | ||
}) | ||
) | ||
) | ||
|
@@ -148,14 +148,14 @@ function testRender(type: string, render: typeof renderToString) { | |
createApp( | ||
defineComponent({ | ||
mixins: [ | ||
{ | ||
defineComponent({ | ||
data() { | ||
return { msg: 'hello' } | ||
}, | ||
render(this: any) { | ||
render() { | ||
return h('div', this.msg) | ||
} | ||
} | ||
}) | ||
] | ||
}) | ||
) | ||
|
@@ -675,9 +675,7 @@ function testRender(type: string, render: typeof renderToString) { | |
const MyComp = { | ||
render: () => h('p', 'hello') | ||
} | ||
expect(await render(h(KeepAlive, () => h(MyComp)))).toBe( | ||
`<p>hello</p>` | ||
) | ||
expect(await render(h(KeepAlive, () => h(MyComp)))).toBe(`<p>hello</p>`) | ||
}) | ||
|
||
test('Transition', async () => { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,7 @@ export async function resolveTeleports(context: SSRContext) { | |
// note: it's OK to await sequentially here because the Promises were | ||
// created eagerly in parallel. | ||
context.teleports[key] = await unrollBuffer( | ||
(await Promise.all(context.__teleportBuffers[key])) as SSRBuffer | ||
await Promise.all([context.__teleportBuffers[key]]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can I have a review on this change please, from the type this change makes sense, but from the previous code it seems the |
||
) | ||
} | ||
} | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems typescript 4.7.x is not able to recognise this variable being set on the
constructor
, just in case I've initialised here