fix(types): propagate type parameter constraints for TypeScript 4.8 #6351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielRosenwasser
force-pushed
the
propagateTypeParametrsFor4.8
branch
from
6d5040e to
58e6345
Compare
❌ Deploy Preview for vuejs-coverage failed.
|
sxzz
force-pushed
the
propagateTypeParametrsFor4.8
branch
from
58e6345 to
8a78e6a
Compare
|
This PR seems to have broken vue-i18n's type: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
In TypeScript 4.8, we recently added some stricter checking around unconstrained generics being incompatible with emptyish object types (things that are effectively
{}or{ [key: string]: ... }, etc. The changes are only in nightly versions of TypeScript right now, but we've been exploring how open-source projects have been impacted. These are the changes necessary for Vue's core repo to build cleanly in TypeScript 4.8.