Skip to content

fix(scripts): delete an unnecessary parameter #8527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2023
Merged

fix(scripts): delete an unnecessary parameter #8527

merged 4 commits into from
Nov 10, 2023

Conversation

wangyewei
Copy link
Contributor

The build function takes 1 argument but got 2 in runParallel function.

sxzz
sxzz reviewed Jun 10, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But it would be advisable to add JSDoc for enhanced robustness

@netlify
Copy link

netlify bot commented Jun 15, 2023 •
edited
Loading

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit 9492dff
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/648a941e8e079e000988d368

@netlify
Copy link

netlify bot commented Jun 15, 2023 •
edited
Loading

❌ Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 9492dff
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/648a941efe39a40009d37270

@wangyewei
Copy link
Contributor Author

LGTM.

But it would be advisable to add JSDoc for enhanced robustness

I have added JSDoc.

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 13, 2023
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@yyx990803 yyx990803 merged commit 3b3bcd4 into vuejs:main Nov 10, 2023
@wangyewei wangyewei deleted the comments branch November 10, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangyewei @sxzz @yyx990803