chore(playground): save tsconfig.json to the root directory; update Node.js version requirement
#9086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
Alfred-Skyblue
changed the title
tsconfig.json file when downloadingtsconfig.json update Node.js version requirement
|
Why do you think it's a JavaScript project? TypeScript files can be saved as well. |
Because the package.json does not include dependencies for TypeScript, we can certainly download the tsconfig.json file to the root directory; perhaps this would be a better choice? |
|
Actually a JavaScript project can also use |
|
Yes, if that's the case, we should place the tsconfig.json in the root directory. It will be stored in the project, similar to the import-map.json file. Do you think this approach is viable? |
|
Sure we can move it outside of |
sxzz
added
wait changes
and removed
need more info
|
I have modified |
Alfred-Skyblue
changed the title
tsconfig.json update Node.js version requirementtsconfig.json to the root directory update Node.js version requirement
sxzz
approved these changes
Aug 31, 2023
sxzz
added
ready to merge
haoqunjiang
approved these changes
Mar 12, 2024
haoqunjiang
changed the title
tsconfig.json to the root directory update Node.js version requirementtsconfig.json to the root directory; update Node.js version requirement
lynxlangya
pushed a commit
to lynxlangya/core
that referenced
this pull request
May 30, 2024
… Node.js version requirement (vuejs#9086) Co-authored-by: Haoqun Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
downloadto download a project in the sfc-playground, thetsconfig.jsonfile is being downloaded into thesrcdirectory. Since the downloaded project is a JavaScript project, I overlooked thetsconfig.jsonfile in this PR. [email protected] requires Node.js version 14.18+, 16+ updated README.md for this.