chore: remove @types/estree
#9158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
Jinjiang
approved these changes
Sep 7, 2023
sxzz
force-pushed
the
chore/remove-estree
branch
2 times, most recently
from
7c9fa59 to
7a7a2c2
Compare
haoqunjiang
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Note: I believe this was originally added because estree-walker < 3.0 implicitly depends on estree types.
But now after ae7453f we are actually using a shim for estree-walker types.
So, this dependency is no longer needed. It should be safely removable.
yyx990803
force-pushed
the
chore/remove-estree
branch
from
7a7a2c2 to
44f11d1
Compare
yyx990803
pushed a commit
that referenced
this pull request
Oct 21, 2023
lumozx
pushed a commit
to lumozx/core
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not be used