fix(renderer): fix patch error in unstable slot #9202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
please add unit test |
| n1.dynamicChildren | ||
| n1.dynamicChildren && | ||
| // #9200 in some case stable fragment in deep unstable slot | ||
| n1?.children?.length === n2?.children?.length |
There was a problem hiding this comment.
We should avoid using optional chaining #4882 (comment)
There was a problem hiding this comment.
removed optional chaining
baiwusanyu-c
suggested changes
Sep 13, 2023
edison1105
requested changes
Sep 13, 2023
| n1.dynamicChildren | ||
| n1.dynamicChildren && | ||
| // #9200 in some case stable fragment in deep unstable slot | ||
| n1?.children?.length === n2?.children?.length |
There was a problem hiding this comment.
Suggested change
| n1?.children?.length === n2?.children?.length | |
| dynamicChildren.length === n1.dynamicChildren.length |
added unit test |
linghaoSu
requested review from
baiwusanyu-c,
edison1105 and
Alfred-Skyblue
linghaoSu
force-pushed
the
fix/renderer-unstable-slot
branch
from
8a48ff5 to
3ec274b
Compare
edison1105
requested changes
Sep 14, 2023
| @@ -351,4 +355,121 @@ describe('renderer: fragment', () => { | |||
| render(renderFn(['two', 'one']), root) | |||
| expect(serializeInner(root)).toBe(`text<div>two</div>text<div>one</div>`) | |||
| }) | |||
|
|
|||
| // #9200 | |||
| test('stable fragment in unstable slot', () => { | |||
There was a problem hiding this comment.
this test case is too complex to understand.
here is a simple one
|
@linghaoSu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9200
live demo