Shuffle team members #1880
Merged
Shuffle team members #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The avatar doesn't seem to match the person? See the screenshot below:
|
NataliaTepluhina
approved these changes
Aug 4, 2022
|
@NataliaTepluhina Did you notice the bug mentioned above? If you refresh the page, the avatars no longer match their profiles. |
|
let me take a look |
|
|
|
There is another bug. I can't reproduce them on my local machine.
|
|
Caused by the SSG process (for both the mismatch and layout). Fixed in #1880 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Shuffle team members like the v2 doc site.
Proposed Solution
Provide a
shuffleMembers()function to process the data ahead.Additional Information
It's on the TODO list of
@vue/theme. However, now I feel it's better done here. Thanks.vuejs/theme#36