Swapping indexOf to includes in comparisons
#1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proposal is to remove the usage of the `indexOf` method when testing for the presence of a given character in a string. While `indexOf` is compatible with IE, `includes` is friendlier to newer JavaScript developers and it improves code readability.
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
NataliaTepluhina
approved these changes
Aug 4, 2022
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 4, 2022
This proposal is to remove the usage of the `indexOf` method when testing for the presence of a given character in a string. While `indexOf` is compatible with IE, `includes` is friendlier to newer JavaScript developers and it improves code readability.
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
This proposal is to remove the usage of the `indexOf` method when testing for the presence of a given character in a string. While `indexOf` is compatible with IE, `includes` is friendlier to newer JavaScript developers and it improves code readability. Co-authored-by: Oliver Mitchell <[email protected]>
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
…e/components/attrs.mdCo-authored-by: Natalia Tepluhina <[email protected]> (#42) (#43) * Swapping `indexOf` to `includes` in comparisons (#1885) This proposal is to remove the usage of the `indexOf` method when testing for the presence of a given character in a string. While `indexOf` is compatible with IE, `includes` is friendlier to newer JavaScript developers and it improves code readability. * Minor lexical improvements to composables.md (#1875) * Minor lexical improvements to composables.md * Update src/guide/reusability/composables.md Co-authored-by: skirtle <[email protected]> Co-authored-by: skirtle <[email protected]> * Missing 'the' in attrs.md (#1874) * Missing 'the' in attrs.md * Update src/guide/components/attrs.md Co-authored-by: Natalia Tepluhina <[email protected]> Co-authored-by: Oliver Mitchell <[email protected]> Co-authored-by: mst101 <[email protected]> Co-authored-by: skirtle <[email protected]> Co-authored-by: Natalia Tepluhina <[email protected]>
edimitchel
referenced
this pull request
in vuejs-translations/docs-fr
Aug 22, 2022
…nts to composables.md* Update src/guide/reusability/composables.mdCo-authored-by: skirtle <[email protected]>Co-authored-by: skirtle <[email protected]> (#40) (#41) * Swapping `indexOf` to `includes` in comparisons (#1885) This proposal is to remove the usage of the `indexOf` method when testing for the presence of a given character in a string. While `indexOf` is compatible with IE, `includes` is friendlier to newer JavaScript developers and it improves code readability. * Minor lexical improvements to composables.md (#1875) * Minor lexical improvements to composables.md * Update src/guide/reusability/composables.md Co-authored-by: skirtle <[email protected]> Co-authored-by: skirtle <[email protected]> Co-authored-by: Oliver Mitchell <[email protected]> Co-authored-by: mst101 <[email protected]> Co-authored-by: skirtle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal is to remove the usage of the
indexOfmethod when testing for the presence of a given character in a string. WhileindexOfis compatible with IE,includesis friendlier to newer JavaScript developers and it improves code readability.Description of Problem
indexOfis the legacy method of checking if a string contains a substring.Proposed Solution
Removing usage of
indexOfand replacing withincludesAdditional Information