docs: document mixing named and default slots #1946
Conversation
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Thanks for the PR!
I think there may be a couple of problems with explaining it this way:
- It appears to contradict the example that immediately precedes it, which mixes named slots and the default slot quite happily, without using
#default. The problem only occurs whenv-slot/#defaultis explicitly used on the parent tag. If it is omitted then everything works fine. - This new example is using a scoped slot before the concept of scoped slot has been introduced.
I think we may need to move this explanation further down, because scoped slots are the key reason why somebody would run into this problem in the first place. Maybe in the section about Named Scoped Slots?
|
That's what I did in my first commit, I finally decided to move it earlier after mixing the slots. I'll do that ! |
Co-authored-by: skirtle <[email protected]>
Co-authored-by: skirtle <[email protected]>
Co-authored-by: skirtle <[email protected]>
Co-authored-by: skirtle <[email protected]>
|
@skirtles-code it's totally clear, I used your suggestions. |
There was a problem hiding this comment.
@noook thank you for the contribution and thanks to @skirtles-code for the detailed review! PR looks good to me, let's get it merged
vuejs/core#6549
Description of Problem
Regarding this issue, the compiler doesn't inform what's the real problem with mixing named slot and default. This PR updates the documentation to explain how to avoid this error. The compiler error still needs to be clearer.
Proposed Solution
Provide an example on how to use default slots along named slots
Additional Information
—