Skip to content

add notes in lifecycle hooks #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

add notes in lifecycle hooks #1968

merged 1 commit into from
Sep 23, 2022

Conversation

jay-es
Copy link
Contributor

@jay-es jay-es commented Sep 23, 2022

I added notes to renderTracked and renderTriggered as same as Composition API.

@netlify
Copy link

netlify bot commented Sep 23, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 09ad2c1
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/632d1f7f9091840009bade94
😎 Deploy Preview https://deploy-preview-1968--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I agree, we should have the same notes for both APIs.

@skirtles-code skirtles-code merged commit 6d2dc93 into vuejs:main Sep 23, 2022
@jay-es jay-es deleted the lifecycle branch September 23, 2022 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants