-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Update: watchers.md #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: watchers.md #2069
Conversation
Add `Eager Watchers` section to composition side
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, this does need to be covered.
I've provided some feedback on your proposed changes below.
Thank you, I considered your review |
@JohnnyEvo Thanks for making those changes. I've just had another read through and I think we now have a problem with the section about Would you like to attempt that rewording yourself? If not then I can give it a go. |
@skirtles-code I'm not sure I understand what is problematic. Here's my proposal, I'll let you rework it if that doesn't work. Thanks |
The problem is that the With hindsight I don't think the omission of the section about eager watcher is an oversight. I think it was intentional, with the section about |
I understand the inconsistency. |
I've pulled these commits into #2144 and made some changes to the |
Add
Eager Watchers
section to composition sideDescription of Problem
When we are in
composition
option,Eager watchers
is not mentioned.Proposed Solution
Add
Eager watchers
incomposition
option.Additional Information