Skip to content

Update application.md #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2023
Merged

Update application.md #2138

merged 2 commits into from
Jan 1, 2023

Conversation

Heniker
Copy link
Contributor

@Heniker Heniker commented Dec 26, 2022

Description of Problem

Guide Augmenting Global Properties is hard to find, because it is located under Options API section, while it actually has uses in Composition API as well.

Proposed Solution

Mention Augmenting Global Properties under app.config.globalProperties.

Additional Information

Mention [Augmenting Global Properties](https://vuejs.org/guide/typescript/options-api.html#augmenting-global-properties) under `app.config.globalProperties`. This guide is really hard to find, because it is in Options API section, while it actually has uses in Composition API as well.
@netlify
Copy link

netlify bot commented Dec 26, 2022

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit ffefdc8
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/63afe4ce149d2c000883bf15
😎 Deploy Preview https://deploy-preview-2138--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

I suggest adding the TS badge at the end (see below). I'm not sure how consistent we are with this, but links to TS-specific topics are supposed to have that badge.

@Heniker
Copy link
Contributor Author

Heniker commented Dec 31, 2022

Yea, that makes sense. Accepted change.

@skirtles-code skirtles-code merged commit a138a2a into vuejs:main Jan 1, 2023
Alex-Sokolov referenced this pull request in vuejs-translations/docs-ru Jan 1, 2023
* Update application.md

Mention [Augmenting Global Properties](https://vuejs.org/guide/typescript/options-api.html#augmenting-global-properties) under `app.config.globalProperties`. This guide is really hard to find, because it is in Options API section, while it actually has uses in Composition API as well.

* Update src/api/application.md

Co-authored-by: skirtle <[email protected]>

Co-authored-by: skirtle <[email protected]>
Alex-Sokolov referenced this pull request in vuejs-translations/docs-ru Jan 1, 2023
* Update application.md

Mention [Augmenting Global Properties](https://vuejs.org/guide/typescript/options-api.html#augmenting-global-properties) under `app.config.globalProperties`. This guide is really hard to find, because it is in Options API section, while it actually has uses in Composition API as well.

* Update src/api/application.md

Co-authored-by: skirtle <[email protected]>

Co-authored-by: skirtle <[email protected]>

Co-authored-by: Heniker <[email protected]>
Co-authored-by: skirtle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants