Add a comment about not importing defineExpose #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
NataliaTepluhina
approved these changes
Jan 2, 2023
Alex-Sokolov
referenced
this pull request
in vuejs-translations/docs-ru
Jan 2, 2023
Alex-Sokolov
referenced
this pull request
in vuejs-translations/docs-ru
Jan 2, 2023
* Add class to the Skip Link in the accessibility.md (#2123) - CSS syntax is case-insensitive so it is better to use kebab case (skip-link) instead of camel case (skipLink) - The anchor tag must have a class of skip-link * Add a comment about not importing defineExpose (#2140) Co-authored-by: Szilard Orban <[email protected]> Co-authored-by: skirtle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2126, the example that introduces
defineExposedoesn't currently mention that it shouldn't be imported. I've added a comment to try to address that.From what I can tell, this is the first point in the guides that the concept of compiler macros is mentioned. We haven't yet introduced
definePropsordefineEmits. I imagine a lot of people won't be clear what a 'macro' is in this context. This PR doesn't attempt to address that problem directly, though I have used the term 'compiler macro' rather than just 'macro' in the comment.