Skip to content

docs: consistent colons in input labels #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023
Merged

docs: consistent colons in input labels #2557

merged 2 commits into from
Oct 31, 2023

Conversation

andrewvasilchuk
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit e508a9f
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6540d33cec25d4000865cd6c
😎 Deploy Preview https://deploy-preview-2557--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The consistency is a good catch 👍

@bencodezen bencodezen merged commit a6c8282 into vuejs:main Oct 31, 2023
mostafa-nematpour referenced this pull request in vuejs-translations/docs-fa Nov 5, 2023
* Revert "Add Vue Toronto banner - schedule 2 (#2536)" (#2553)

This reverts commit 71ecfd5.

* Remove the app constant name from the method name (#2523)

* Remove the app variable name from the method name

To be consitent with the rest of the guide, it should be displayed the method name (with the dot accessor)
i.e.: https://vuejs.org/guide/essentials/application.html#mounting-the-app

* remove app const name from method

* Update rules-recommended.md (#2540)

docs: add missing div to seperate bad and good examples

* Update events.md - Diff between Options API and Composition API text (#2550)

* Update events.md - Diff between Options API and Composition API text

The emits support for object sintax for Options API text was displayed for both, Options and Composition API.

* Update events.md - in span instead of repeat code in different divs

* Update events.md - fix options-api class

* Update src/guide/components/events.md

Co-authored-by: Natalia Tepluhina <[email protected]>

---------

Co-authored-by: Natalia Tepluhina <[email protected]>

* Add missing ':' on duration property (#2556)

* docs: consistent colons in input labels (#2557)

* docs: consistent colons in input labels

* Update colons everywhere

* docs: use useByRole in example and fix typos (#2559)

getByRole validates the role of an element, giving us an extra free assertion

https://testing-library.com/docs/queries/about/#priority

* chore(deps): bump @vue/theme from 2.2.4 to 2.2.5 (#2555)

Bumps [@vue/theme](https://github.com/vuejs/theme) from 2.2.4 to 2.2.5.
- [Commits](https://github.com/vuejs/theme/commits/v2.2.5)

---
updated-dependencies:
- dependency-name: "@vue/theme"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix `watch` examples (#2537)

* Add note to `watch` examples

* fix watch examples

* fix: fixed disabling an input

---------

Co-authored-by: NataliaTepluhina <[email protected]>

* imported and changed twitter icon to new logo (#2548)

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Evan You <[email protected]>
Co-authored-by: Leo <[email protected]>
Co-authored-by: Jérémie LITZLER <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: cabbageshop <[email protected]>
Co-authored-by: Andrew <[email protected]>
Co-authored-by: Yakir Gottesman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jun Shindo <[email protected]>
Co-authored-by: stevenks17 <[email protected]>
@andrewvasilchuk andrewvasilchuk deleted the patch-1 branch November 11, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants