docs: use useByRole in example and fix typos #2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getByRole validates the role of an element, giving us an extra free assertion https://testing-library.com/docs/queries/about/#priority
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NataliaTepluhina
approved these changes
Nov 2, 2023
mostafa-nematpour
referenced
this pull request
in vuejs-translations/docs-fa
Nov 5, 2023
* Revert "Add Vue Toronto banner - schedule 2 (#2536)" (#2553) This reverts commit 71ecfd5. * Remove the app constant name from the method name (#2523) * Remove the app variable name from the method name To be consitent with the rest of the guide, it should be displayed the method name (with the dot accessor) i.e.: https://vuejs.org/guide/essentials/application.html#mounting-the-app * remove app const name from method * Update rules-recommended.md (#2540) docs: add missing div to seperate bad and good examples * Update events.md - Diff between Options API and Composition API text (#2550) * Update events.md - Diff between Options API and Composition API text The emits support for object sintax for Options API text was displayed for both, Options and Composition API. * Update events.md - in span instead of repeat code in different divs * Update events.md - fix options-api class * Update src/guide/components/events.md Co-authored-by: Natalia Tepluhina <[email protected]> --------- Co-authored-by: Natalia Tepluhina <[email protected]> * Add missing ':' on duration property (#2556) * docs: consistent colons in input labels (#2557) * docs: consistent colons in input labels * Update colons everywhere * docs: use useByRole in example and fix typos (#2559) getByRole validates the role of an element, giving us an extra free assertion https://testing-library.com/docs/queries/about/#priority * chore(deps): bump @vue/theme from 2.2.4 to 2.2.5 (#2555) Bumps [@vue/theme](https://github.com/vuejs/theme) from 2.2.4 to 2.2.5. - [Commits](https://github.com/vuejs/theme/commits/v2.2.5) --- updated-dependencies: - dependency-name: "@vue/theme" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix `watch` examples (#2537) * Add note to `watch` examples * fix watch examples * fix: fixed disabling an input --------- Co-authored-by: NataliaTepluhina <[email protected]> * imported and changed twitter icon to new logo (#2548) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Evan You <[email protected]> Co-authored-by: Leo <[email protected]> Co-authored-by: Jérémie LITZLER <[email protected]> Co-authored-by: Natalia Tepluhina <[email protected]> Co-authored-by: cabbageshop <[email protected]> Co-authored-by: Andrew <[email protected]> Co-authored-by: Yakir Gottesman <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jun Shindo <[email protected]> Co-authored-by: stevenks17 <[email protected]>
nazarepiedady
pushed a commit
to nazarepiedady/vue3-docs
that referenced
this pull request
Nov 30, 2023
getByRole validates the role of an element, giving us an extra free assertion https://testing-library.com/docs/queries/about/#priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
const button = getByText('increment')is using getByText, which is not optimal. It also uses an exact match, which could give a false negative if we decide to change the character case of the button text.Proposed Solution
getByRole validates the role of an element, giving us an extra free assertion
https://testing-library.com/docs/queries/about/#priority
Additional Information
It is not a critical change, but I appreciate testing-library, and want to educate people on how to utilize it better. Also, I hope Grammarly did a good job assisting me with catching typos 🤷♂️.