Skip to content

feat: use shikiji for more accurate highlight #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: use shikiji for more accurate highlight #190

merged 1 commit into from
Dec 21, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Dec 16, 2023 •
edited
Loading

A few advantages:

  • More accurate highlight result
    • Shikiji supports grammar injections, which means it allows Vue grammar to inject rules into HTML grammar, and have it understand Vue interoperation in the template (previously treated as plain texts)
  • Reuse all themes Shikiji/TextMate supports (hard-coded in this PR)
  • Shikiji's syntax always keeps up to date with vuejs/language-tools
  • Possible to share the shikiji highlighter if it also been used by other parts of the app.

Before:
Screenshot 2023-12-16 at 06 24 47

After:
Screenshot 2023-12-16 at 06 24 19

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 6:16am

sxzz
sxzz approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxzz sxzz requested a review from johnsoncodehk December 16, 2023 06:37
@sxzz sxzz merged commit e79aa1a into vuejs:main Dec 21, 2023
@antfu antfu deleted the feat/shikiji branch December 21, 2023 15:04
oumoussa98 pushed a commit to vuetifyjs/vue-repl that referenced this pull request Apr 18, 2025
@antfu @oumoussa98
feat: use shikiji for more accurate highlight (vuejs#190)
63c92de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

@johnsoncodehk johnsoncodehk johnsoncodehk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antfu @sxzz @johnsoncodehk