Skip to content

Add new banner for Vuemastery free weekend #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 5, 2020
Merged

Add new banner for Vuemastery free weekend #2512

merged 21 commits into from
Mar 5, 2020

Conversation

pieer
Copy link
Contributor

@pieer pieer commented Mar 4, 2020

No description provided.

@phanan phanan requested a review from yyx990803 March 4, 2020 10:06
@yyx990803 yyx990803 merged commit b22219e into vuejs:master Mar 5, 2020
@@ -14,6 +14,7 @@
@import "_style-guide"
@import "_modal"
@import "_scrimba"
@import "_vuemastery-banner"
@import "_vue-mastery"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #2515 I suspect this line needs to match the file rename with @import _vuemastery or revert the filename change. Explains an empty https://vuejs.org/css/page.css anyways. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants