-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix API URL #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API URL #2973
Conversation
✅ Deploy Preview for vuejs-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@cfjedimaster would you mind taking a look at this PR and the corresponding CodePen of yours? Thanks. |
Hmm, the API isn't responding. Let me check w/ Netlify. |
So - the site is up and running. When I hit the function, I get no response. I haven't looked at the code for the site in 3 years. So yeah, this PR should be accepted as the URL -is- fixed, but the actual function isn't reliable anymore. I'd probably suggest rewriting the demo to hit a fake API so we aren't reliant on an external site. |
Sorry, I didn't quite understand what you mean by hitting a fake API. Can you explain a bit more? |
Instead of hitting a 'real' API, we run a method that has a fake delay, lets say 2 seconds, and returns static data (well, dynamic based on name, if i remember correctly how the old function worked). |
You mean something like this?
But I think since this code is under |
Oh I feel dumb. I forgot the serverless function returns status 204 on success, with no content. The function is working fine as is, I just didn't realize. I saw just accept the PR and move on! :) |
Can anyone having access of the CodePen modify the |
That's me - and done. :) |
Thanks :) |
The previous URL was not working properly.
The URL on CodePen also needs to be changed.