-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Portuguese language #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for eager-kowalevski-41f498 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Great job! |
@jay-es, I am the one who has to say sorry, I confused you with a maintainer 😅 |
@@ -21,6 +21,16 @@ | |||
fill: #231f20; | |||
} | |||
|
|||
@media (prefers-color-scheme: dark) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I have more information and background about this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes, I tried to do some kind of enhancement to the dark mode presentation of this SVG file because the current one is a little uncomfortable to the eyes. This is a colour modification of the SVG file I did based on the user's colour scheme preferences.
Below, you can see what I was trying to do, @Jinjiang
current dark mode | new dark mode in the pull request |
---|---|
![]() |
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Great job. Just would be better if it could be a separated PR next time. :-)
I will approve and merge it shortly. Thanks.
In this pull request, I am finally adding the Portuguese language to the available languages on the website to match with the work in the vuejs-translations/docs-pt, so I hope this will be helpful like the official Portuguese documentation of Vue.js is being.
@Jinjiang
could you do the honour of applying it?