Skip to content

feat: Portuguese language #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Oct 25, 2023
Merged

Conversation

nazarepiedady
Copy link
Contributor

@nazarepiedady nazarepiedady commented Oct 23, 2023

In this pull request, I am finally adding the Portuguese language to the available languages on the website to match with the work in the vuejs-translations/docs-pt, so I hope this will be helpful like the official Portuguese documentation of Vue.js is being.

@Jinjiang

could you do the honour of applying it?

@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for eager-kowalevski-41f498 ready!

Name Link
🔨 Latest commit 9f0f610
🔍 Latest deploy log https://app.netlify.com/sites/eager-kowalevski-41f498/deploys/653633680e7d360007195244
😎 Deploy Preview https://deploy-preview-61--eager-kowalevski-41f498.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jay-es
Copy link
Contributor

jay-es commented Oct 23, 2023

Great job!
But sorry, I'm not the admin of this repository, just a committer.

@nazarepiedady
Copy link
Contributor Author

Great job! But sorry, I'm not the admin of this repository, just a committer.

@jay-es, I am the one who has to say sorry, I confused you with a maintainer 😅

@@ -21,6 +21,16 @@
fill: #231f20;
}

@media (prefers-color-scheme: dark) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I have more information and background about this change?

Copy link
Contributor Author

@nazarepiedady nazarepiedady Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, I tried to do some kind of enhancement to the dark mode presentation of this SVG file because the current one is a little uncomfortable to the eyes. This is a colour modification of the SVG file I did based on the user's colour scheme preferences.

Below, you can see what I was trying to do, @Jinjiang

current dark mode new dark mode in the pull request
vue3-migration-guide-old-dark-theme vue3-migration-guide-new-dark-theme

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Great job. Just would be better if it could be a separated PR next time. :-)
I will approve and merge it shortly. Thanks.

@Jinjiang Jinjiang merged commit e0f492e into vuejs:main Oct 25, 2023
@nazarepiedady nazarepiedady deleted the translate-to-portuguese branch March 13, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants