Skip to content

should not collect uninitialized class properties #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2016
Merged

should not collect uninitialized class properties #35

merged 1 commit into from
Nov 18, 2016

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Nov 18, 2016

In the environment of Babel + Decorator, decorated class properties are treated as enumerable even if we does not set initial value. That causes unexpected initialization of data, reported on #31

I've just added undefined check in the data collection process.

@yyx990803 yyx990803 merged commit 941bef4 into vuejs:master Nov 18, 2016
@ktsn ktsn deleted the babel-decorator branch November 18, 2016 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants