Add registerHooks method to Component decorator #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| const Component: ComponentDecorator = function <V extends VueClass>( | ||
| options: Vue.ComponentOptions<any> | V |
There was a problem hiding this comment.
Can we replace any with Vue?
| if (typeof options === 'function') { | ||
| return componentFactory(options) | ||
| } | ||
| return function (Component: V) { | ||
| return componentFactory(Component, options) | ||
| } | ||
| } as any |
There was a problem hiding this comment.
I would suggest to use namespace trick to bypass type assertion. Here is an example https://github.com/HerringtonDarkholme/av-ts/blob/master/src/core.ts#L173
There was a problem hiding this comment.
Oh, it's nice trick, thanks!
HerringtonDarkholme
approved these changes
Dec 17, 2016
|
Any other comments? |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows us to register additional hooks for class components like Vue Router's
beforeRouteEnter.Close #38