Skip to content

feat: pass styleOption into compiler #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

Szymon-dziewonski
Copy link
Contributor

@Szymon-dziewonski Szymon-dziewonski commented Oct 8, 2021

From https://github.com/sass/dart-sass/releases/tag/1.34.0 there are new couple breaking changes e.g 10/2 now should be written as math.div(10/2). With that change there deprecated message info which pollutes logs.
Of course for your own code people can adjust scss/sass/less files, however for external libraries like bootstrap 4 it's not possible, which means there is a lot of info messages that slows build time. For webpack build we can pass options
Add a --quiet-deps flag which silences compiler warnings from stylesheets loaded through --load-paths.
like

loaderOptions: {
    sass: {
        sassOptions: {
           quietDeps: true,
       }
    },
},

Thats why I did this PR because its no possible for jest tests to pass additional options such as quietDeps: true

@lmiller1990
Copy link
Member

Seems fine, thanks! I can release this in the next few days.

@lmiller1990 lmiller1990 merged commit 4012b2c into vuejs:master Oct 8, 2021
@lmiller1990
Copy link
Member

Do we need something similar for the v3 package?

@Szymon-dziewonski Szymon-dziewonski deleted the feat--style-options branch October 8, 2021 14:01
@Szymon-dziewonski
Copy link
Contributor Author

@lmiller1990 Thank you, probably yes, can be done for v3 too, which I missed, my bad

@Szymon-dziewonski
Copy link
Contributor Author

@lmiller1990 I can probably create another PR for v3 version if you would like me to do :)

@lmiller1990
Copy link
Member

Sure, that'd be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants