Skip to content

feat: add a default component for nested routes #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

deckar01
Copy link

Fixes #2105

Allows nested child routes to render inside routes without a component. Previously this prevented the child route's component from rendering without any warning. Now the parent's component will default to a PassThrough component that provides the <router-view> the child needs to render in.

@deckar01
Copy link
Author

deckar01 commented Aug 23, 2019

This needs docs and more test coverage, but I thought I should get some feedback before investing any more time into this.

@posva
Copy link
Member

posva commented Aug 24, 2019

I appreciate the initiative but this is not something we want to add, at least yet. That's also why the issue was closed.

A note about the implementation you made: the component should be functional and there should be a render function instead of a template

@posva posva closed this Aug 24, 2019
@deckar01-bot
Copy link

I will just fork then. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow nested routes without parent component
3 participants