fix #1793 (Add WrapperArray#exists docs) #1795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrian
commented
Feb 22, 2021
| @@ -208,7 +208,7 @@ export default class Wrapper implements BaseWrapper { | |||
| } | |||
|
|
|||
| /** | |||
| * Utility to check wrapper exists. Returns true as Wrapper always exists | |||
| * Utility to check wrapper exists. | |||
There was a problem hiding this comment.
This appeared to be an outdated comment for the exists method, since it a Wrapper doesn't always exist, since it can return false 🙂
|
@afontcu Would you review this, please? |
afontcu
approved these changes
Feb 22, 2021
| @@ -208,7 +208,7 @@ export default class Wrapper implements BaseWrapper { | |||
| } | |||
|
|
|||
| /** | |||
| * Utility to check wrapper exists. Returns true as Wrapper always exists | |||
| * Utility to check wrapper exists. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)