-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Dev: Hint in console when v-show used on element with the inline 'display: none;' #3484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As stated in the changelog, v-show now respects the original display value of the element. Why would you set it to none? |
Indeed. This is irrational. We've seen situation when |
The change is ment to fix the situation where 'display: none' is set in the CSS, while just removing the display from dom would keep it invisible. It does make sense to completely remove it if the display is set to none, though. @chrisvfritz, what do you think? |
@miljan-aleksic thanks! This is exactly the topic of debate in the office. What should be happening in this case? Drop inline CSS. What should be set back when The only thing we agreed after debate is that small warning from Vue in the console (when in devmode of course) will not hurt :) |
I think
|
Uh oh!
There was an error while loading. Please reload this page.
v-show
will be flippingnone
tonone
. It is developer's mistake, but feels likev-show
doesn't work as expected.Vue version: 2.0.0-rc.2
The text was updated successfully, but these errors were encountered: