object的倒序排列会在一些特殊环境下造成影响(如数据库字段依赖JSON顺序时) #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,8 +48,7 @@ export function Observer (value) { | |||
|
|
|||
| Observer.prototype.walk = function (obj) { | |||
| var keys = Object.keys(obj) | |||
| var i = keys.length | |||
| while (i--) { | |||
| for (var i = 0; i < keys.length; i++) { | |||
There was a problem hiding this comment.
这里三处都按惯例 cache 一下数组长度吧，var i = 0, l = keys.length; i < l; i++
There was a problem hiding this comment.
另外修改完毕后最好合并成一个 commit（force push 到原 branch 即可）
|
@yyx990803 哦了 |
yyx990803
added a commit
that referenced
this pull request
Dec 24, 2015
object的倒序排列会在一些特殊环境下造成影响(如数据库字段依赖JSON顺序时)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2008
解决此issue中出现的特殊问题
发现和解决都是@yuhere 做的，我只是帮他提一个PR