SSR: eliminate closure in render.js implementation #4007
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to remove closures in src/server/render.js.
Removing closures can improve runtime performance, enable easier reasoning about memory leakage, and prevent erroneous captured variable reused.
The basic idea is to pack all captured variable into a
RenderContext
structure. In closure based implementation, all state changes are implicitly stored by wrappingnext
function. In context based implementation state transitions are explicitly recorded inrenderStates
property.I have ran a preliminary benchmark here by running
npn run bench:ssr
.It seems closure elimination can achieve 20% performance boost.
#4002 has also been fixed in this, because contexts are separated between two render function.