Skip to content

Add objects support to v-attr #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2015
Merged

Add objects support to v-attr #902

merged 1 commit into from
Jun 6, 2015

Conversation

OEvgeny
Copy link

@OEvgeny OEvgeny commented Jun 6, 2015

The goal is to add to v-attr directive support for objects:

<div v-attr="obj"></div>

Demo here: http://jsfiddle.net/nd9baygn/3/

Waiting for suggestions patiently :)

@yyx990803
Copy link
Member

Looking good! Let's just make things consistent to resemble the updated v-style implementation: https://github.com/yyx990803/vue/blob/dev/src/directives/style.js

I think the logic should be equivalent and I don't see the need to store the previous object as this.obj.

@OEvgeny
Copy link
Author

OEvgeny commented Jun 6, 2015

Done!

yyx990803 added a commit that referenced this pull request Jun 6, 2015
Add objects support to v-attr
@yyx990803 yyx990803 merged commit 8639749 into vuejs:dev Jun 6, 2015
@yyx990803
Copy link
Member

good job!

@OEvgeny OEvgeny mentioned this pull request Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants