Skip to content

docs(ja): translate new options for the subscribe methods and logger plugin #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2020
Merged

docs(ja): translate new options for the subscribe methods and logger plugin #1728

merged 1 commit into from
Apr 25, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Apr 25, 2020

This PR adds the Japanese translation for the new options added to subscribe methods and logger plugin.

@kiaking kiaking added the documentation Improvements or additions to documentation label Apr 25, 2020
@kiaking kiaking requested review from kazupon and ktsn April 25, 2020 09:19
@kiaking kiaking self-assigned this Apr 25, 2020
ktsn
ktsn approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktsn ktsn merged commit 4bcc96a into dev Apr 25, 2020
@ktsn ktsn deleted the docs-ja-update-subscribe-api branch April 25, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

@kazupon kazupon Awaiting requested review from kazupon

Assignees

@kiaking kiaking

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiaking @ktsn