Skip to content

Model $delete method should be synchronous #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cuebit opened this issue Jun 8, 2021 · 0 comments · Fixed by #77
Closed

Model $delete method should be synchronous #76

cuebit opened this issue Jun 8, 2021 · 0 comments · Fixed by #77
Labels
bug Something isn't working

Comments

@cuebit
Copy link
Member

cuebit commented Jun 8, 2021 •
edited
Loading

Describe the bug

Model method $delete returns a promise despite all API methods now being synchronous.

Expected behavior

The method should be synchronous.

Versions

  • Vuex ORM: 1.0.0-draft.14
@cuebit cuebit added the bug Something isn't working label Jun 8, 2021
@cuebit cuebit mentioned this issue Jun 8, 2021
Merged
10 tasks
kiaking pushed a commit that referenced this issue Jun 8, 2021
@cuebit
fix(model): delete method should be synchronous (#76) (#77)
4fb4673 
fix #76

In addition, tests are revised to reflect the synchronous behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(model): delete method should be synchronous (#76) vuex-orm/vuex-orm-next
1 participant
@cuebit