updating tests and adding completer

Author: Bhavin Shah

src/Support/Support.Test/Properties/AssemblyInfo.cs

@@ -45,6 +45,6 @@
 //
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("0.1.0")]
-[assembly: AssemblyFileVersion("0.1.0")]
+[assembly: AssemblyVersion("1.0.0")]
+[assembly: AssemblyFileVersion("1.0.0")]
 [assembly: CollectionBehavior(DisableTestParallelization = true)]

src/Support/Support.Test/ScenarioTests/SupportTicketTests.cs

@@ -128,11 +128,25 @@ public void UpdateAzSupportTicketParentObjectParameterSetUpdateSeverity()
             TestController.NewInstance.RunPowerShellTest(_logger, "Update-AzSupportTicketParentObjectParameterSetUpdateSeverity");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void UpdateAzSupportTicketNameParameterSetUpdateSeverity()
+        {
+            TestController.NewInstance.RunPowerShellTest(_logger, "Update-AzSupportTicketNameParameterSetUpdateSeverity");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void UpdateAzSupportTicketParentObjectParameterSetUpdateStatus()
         {
             TestController.NewInstance.RunPowerShellTest(_logger, "Update-AzSupportTicketParentObjectParameterSetUpdateSeverity");
         }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void UpdateAzSupportTicketNameParameterSetUpdateStatus()
+        {
+            TestController.NewInstance.RunPowerShellTest(_logger, "Update-AzSupportTicketNameParameterSetUpdateStatus");
+        }
     }
 }

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.CommunicationTests/GetAzSupportTicketCommunicationByNameParameterSet.json

@@ -8,7 +8,7 @@
   <Import Project="$(MSBuildThisFileDirectory)..\..\Az.Test.props" />
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Support" Version="1.0.0-preview.1" />
+    <PackageReference Include="Microsoft.Azure.Management.Support" Version="1.0.0" />
   </ItemGroup>
 
 </Project>

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.CommunicationTests/GetAzSupportTicketCommunicationByParentObjectParameterSet.json

@@ -0,0 +1,69 @@
+using Microsoft.Azure.Commands.Common.Authentication;
+using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
+using Microsoft.Azure.Commands.Support.Helpers;
+using Microsoft.Azure.Commands.Support.Models;
+using Microsoft.Azure.Management.Support;
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Management.Automation;
+
+namespace Microsoft.Azure.PowerShell.Cmdlets.Support.ArgumentCompleters
+{
+    public class ServiceIdCompleter : ArgumentCompleterAttribute
+    {
+        private static int _timeout = 3;
+
+        public ServiceIdCompleter() : base(CreateScriptBlock())
+        {
+        }
+
+        public static PSSupportService[] FindResources()
+        {
+            try
+            {
+                var ids = GetServices();
+
+                return ids.ToArray();
+            }
+            catch (Exception)
+            {
+            }
+
+            return new PSSupportService[0];
+        }
+
+        public static List<PSSupportService> GetServices()
+        {
+            var context = AzureRmProfileProvider.Instance?.Profile?.DefaultContext;
+            var supportClient = AzureSession.Instance.ClientFactory.CreateArmClient<MicrosoftSupportClient>(context, AzureEnvironment.Endpoint.ResourceManager);
+
+            var allProviders = supportClient.Services.ListAsync();
+
+            var timeoutDuration = TimeSpan.FromSeconds(_timeout);
+            var hasNotTimedOut = allProviders.Wait(timeoutDuration);
+            var hasResult = allProviders.Result != null;
+            var isSuccessful = hasNotTimedOut && hasResult;
+
+            return isSuccessful
+                ? allProviders.Result.Select(resource => resource.ToPSSupportService()).ToList()
+                : new List<PSSupportService>();
+        }
+
+
+        /// <summary>
+        /// Create ScriptBlock that registers the correct location for tab completetion of the -Location parameter
+        /// </summary>
+        /// <param name="resourceTypes"></param>
+        /// <returns></returns>
+        public static ScriptBlock CreateScriptBlock()
+        {
+            string script = "param($commandName, $parameterName, $wordToComplete, $commandAst, $fakeBoundParameters)\n";
+
+            script += "$resources = [Microsoft.Azure.PowerShell.Cmdlets.Support.ArgumentCompleters.ServiceIdCompleter]::FindResources()\n" +
+                "$resources | Where-Object { $_.DisplayName -Like \"$wordToComplete*\" } | ForEach-Object { [System.Management.Automation.CompletionResult]::new($_.Id, $_.DisplayName, 'ParameterValue', $_.DisplayName) }";
+            ScriptBlock scriptBlock = ScriptBlock.Create(script);
+            return scriptBlock;
+        }
+    }
+}

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.CommunicationTests/GetAzSupportTicketCommunicationFilterByCommunicationType.json

@@ -28,7 +28,7 @@ public enum Severity
         HighestCriticalImpact
     }
 
-    public enum TicketStatus
+    public enum Status
     {
         Open,
         Closed

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.CommunicationTests/GetAzSupportTicketCommunicationPagingParameters.json

@@ -43,7 +43,6 @@ public class PSSupportService
         /// <summary>
         /// Gets or sets resource types
         /// </summary>
-        [Ps1Xml(Target = ViewControl.Table)]
         public string[] ResourceTypes { get; set; }
     }
 }

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.CommunicationTests/NewAzSupportTicketCommunicationNameParameterSet.json

@@ -19,6 +19,7 @@
 using Microsoft.Azure.Graph.RBAC.Version1_6;
 using Microsoft.Azure.Management.Support;
 using Microsoft.Azure.Management.Support.Models;
+using Microsoft.Azure.PowerShell.Cmdlets.Support.ArgumentCompleters;
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using System.Linq;
 using System.Management.Automation;
@@ -31,6 +32,7 @@ public class GetAzSupportProblemClassification : AzSupportCmdletBase
     {
         [Parameter(Mandatory = true, ParameterSetName = GetByNameParameterSet, HelpMessage = "Service id for which all problem classifications are retrieved.")]
         [Alias("ServiceName")]
+        [ServiceIdCompleter()]
         [ValidateNotNullOrEmpty]
         public string ServiceId { get; set; }
 

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.CommunicationTests/NewAzSupportTicketCommunicationParentObjectParameterSet.json

@@ -25,5 +25,5 @@
 [assembly: ComVisible(false)]
 [assembly: CLSCompliant(false)]
 [assembly: Guid("22d73af7-38c2-4bf6-b56f-4dc9db05d97a")]
-[assembly: AssemblyVersion("0.1.0")]
-[assembly: AssemblyFileVersion("0.1.0")]
+[assembly: AssemblyVersion("1.0.0")]
+[assembly: AssemblyFileVersion("1.0.0")]

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.ProblemClassificationTests/GetAzSupportProblemClassificationAllParametersId.json

@@ -19,6 +19,7 @@
 using Microsoft.Azure.Graph.RBAC.Version1_6;
 using Microsoft.Azure.Management.Support;
 using Microsoft.Azure.Management.Support.Models;
+using Microsoft.Azure.PowerShell.Cmdlets.Support.ArgumentCompleters;
 using System.Linq;
 using System.Management.Automation;
 using static Microsoft.Azure.Commands.Support.Helpers.ResourceIdentifierHelper;
@@ -30,6 +31,7 @@ public class GetAzSupportService : AzSupportCmdletBase
     {
         [Parameter(Mandatory = true, ParameterSetName = GetByNameParameterSet, HelpMessage = "Service id.")]
         [Alias("Name")]
+        [ServiceIdCompleter()]
         [ValidateNotNullOrEmpty]
         public string Id { get; set; }
 

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.ProblemClassificationTests/GetAzSupportProblemClassificationAllParametersNameAlias.json

@@ -6,7 +6,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Support" Version="1.0.0-preview.1" />
+    <PackageReference Include="Microsoft.Azure.Management.Support" Version="1.0.0" />
   </ItemGroup>
 
   <Import Project="$(MSBuildThisFileDirectory)..\..\Az.props" />

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.ProblemClassificationTests/GetAzSupportProblemClassificationAllParametersResourceId.json

@@ -183,7 +183,7 @@ public override void ExecuteCmdlet()
 
                     if (!technicalResourceId.Subscription.Equals(this.SupportClient.SubscriptionId, StringComparison.OrdinalIgnoreCase))
                     {
-                        throw new PSArgumentException(string.Format("TechnicalResourceId {0} does not belong in subscription {1}.", this.TechnicalTicketResourceId, this.SupportClient.SubscriptionId));
+                        throw new PSArgumentException(string.Format("TechnicalResourceId {0} does not belong to subscription {1}.", this.TechnicalTicketResourceId, this.SupportClient.SubscriptionId));
                     }
 
                     var resourceClient = AzureSession.Instance.ClientFactory.CreateArmClient<ResourceManagementClient>(

src/Support/Support.Test/SessionRecords/Microsoft.Azure.Commands.Support.Test.ScenarioTests.ProblemClassificationTests/GetAzSupportProblemClassificationParentObjectAllParameters.json

@@ -42,7 +42,7 @@ public class UpdateAzSupportTicket : AzSupportCmdletBase
         public Severity Severity { get; set; }
 
         [Parameter(Mandatory = false, HelpMessage = "Update Status of SupportTicket.")]
-        public TicketStatus Status { get; set; }
+        public Models.Status Status { get; set; }
 
         [Parameter(Mandatory = true, ParameterSetName = UpdateByNameWithContactObjectParameterSet, HelpMessage = "Update Contact details on SupportTicket.")]
         [Parameter(Mandatory = true, ParameterSetName = UpdateByInputObjectWithContactObjectParameterSet, HelpMessage = "Update Contact details on SupportTicket.")]