Skip to content

Add generated code for Speech to Text service #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 8, 2018

Conversation

lpatino10
Copy link
Contributor

This PR adds the generated models and service class for Speech to Text.

All unit and integration tests have been updated to reflect the changes, and new ones have been added as necessary as well.

Any manual changes necessary post-generation can be found here.

@codecov-io
Copy link

codecov-io commented Feb 3, 2018

Codecov Report

Merging #857 into develop will decrease coverage by 0.63%.
The diff coverage is 53.54%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #857      +/-   ##
=============================================
- Coverage       56.3%   55.67%   -0.64%     
- Complexity      2216     2408     +192     
=============================================
  Files            496      568      +72     
  Lines          12021    13533    +1512     
  Branches         675      715      +40     
=============================================
+ Hits            6768     7534     +766     
- Misses          4861     5600     +739     
- Partials         392      399       +7
Impacted Files Coverage Δ Complexity Δ
...eveloper_cloud/speech_to_text/v1/SpeechToText.java 91.69% <ø> (+12.84%) 85 <0> (+28) ⬆️
...r_cloud/text_to_speech/v1/model/Pronunciation.java 50% <ø> (ø) 2 <0> (ø) ⬇️
.../speech_to_text/v1/model/MultipartRecognition.java 0% <0%> (ø) 0 <0> (?)
.../speech_to_text/v1/model/DeleteSessionOptions.java 0% <0%> (ø) 0 <0> (?)
...oud/text_to_speech/v1/model/ListVoicesOptions.java 0% <0%> (ø) 0 <0> (?)
...r_cloud/speech_to_text/v1/model/SpeechSession.java 0% <0%> (-12.5%) 0 <0> (-2)
...loud/speech_to_text/v1/model/CheckJobsOptions.java 0% <0%> (ø) 0 <0> (?)
...r_cloud/speech_to_text/v1/model/SessionStatus.java 0% <0%> (ø) 0 <0> (?)
.../speech_to_text/v1/model/CreateSessionOptions.java 0% <0%> (ø) 0 <0> (?)
...oud/speech_to_text/v1/model/ListModelsOptions.java 0% <0%> (ø) 0 <0> (?)
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4cb108...54701ef. Read the comment docs.

@germanattanasio
Copy link
Contributor

We need to make sure the RecognizeOptions can be share between the REST and the WebSocket endpoints

• Files passed as body parameters are now `InputStream` types
• The above parameters also have setters using a `File`, which converts
to an `InputStream` internally
• `recognize()` and `recognizeUsingWebSockets()` use the same
`RecognizeOptions`
• Tests written for `registerCallback()` and `unregisterCallback()`
• Some Javadoc comments shortened
@germanattanasio germanattanasio changed the base branch from develop to next February 8, 2018 16:45
@germanattanasio germanattanasio merged commit 202ef1f into next Feb 8, 2018
@germanattanasio germanattanasio deleted the codegen/speech-to-text branch February 8, 2018 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants