-
Notifications
You must be signed in to change notification settings - Fork 531
Add generated code for Speech to Text service #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds all of the generated models and service class. It also updates the tests to pass with new changes.
…degen/speech-to-text
…degen/speech-to-text
Codecov Report
@@ Coverage Diff @@
## develop #857 +/- ##
=============================================
- Coverage 56.3% 55.67% -0.64%
- Complexity 2216 2408 +192
=============================================
Files 496 568 +72
Lines 12021 13533 +1512
Branches 675 715 +40
=============================================
+ Hits 6768 7534 +766
- Misses 4861 5600 +739
- Partials 392 399 +7
Continue to review full report at Codecov.
|
We need to make sure the |
…-sdk into codegen/speech-to-text
• Files passed as body parameters are now `InputStream` types • The above parameters also have setters using a `File`, which converts to an `InputStream` internally • `recognize()` and `recognizeUsingWebSockets()` use the same `RecognizeOptions` • Tests written for `registerCallback()` and `unregisterCallback()` • Some Javadoc comments shortened
germanattanasio
approved these changes
Feb 8, 2018
germanattanasio
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the generated models and service class for Speech to Text.
All unit and integration tests have been updated to reflect the changes, and new ones have been added as necessary as well.
Any manual changes necessary post-generation can be found here.