Skip to content

Fix issues with API diff generation #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Conversation

lpatino10
Copy link
Contributor

Unfortunately, the addition of API diff generation is not working yet. On the latest release, these were the errors thrown in Travis:

screen shot 2018-06-04 at 11 23 16 am

This PR looks to address those to hopefully get things running smoothly.

@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #949 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #949   +/-   ##
==========================================
  Coverage      65.46%   65.46%           
  Complexity      2655     2655           
==========================================
  Files            564      564           
  Lines          14396    14396           
  Branches         824      824           
==========================================
  Hits            9425     9425           
  Misses          4550     4550           
  Partials         421      421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f774d19...111d75f. Read the comment docs.

@germanattanasio germanattanasio merged commit d173cf6 into develop Jun 4, 2018
@germanattanasio germanattanasio deleted the api-diff-fix branch June 4, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants