-
Notifications
You must be signed in to change notification settings - Fork 531
Add codegen updates #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codegen updates #950
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #950 +/- ##
==============================================
- Coverage 65.31% 39.05% -26.27%
+ Complexity 2654 1470 -1184
==============================================
Files 564 580 +16
Lines 14243 14675 +432
Branches 809 840 +31
==============================================
- Hits 9303 5731 -3572
- Misses 4524 8610 +4086
+ Partials 416 334 -82
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍looks good!
The only thing we might want to do is add iam authentication in these two readme files
https://github.com/watson-developer-cloud/java-sdk/blob/generated-updates/language-translator/README.md
https://github.com/watson-developer-cloud/java-sdk/blob/generated-updates/visual-recognition/README.md
Good thinking. I'll add that now and merge. |
This PR adds the newest generated code using the following commits:
a3d247f2d250edf5b9743a41afcfebda52f66cf4
1b4341039c46d6794f65a12932698cb7aeb1c236
Most of the files changed are due to changes in comment formatting, so they can be skimmed.
The main code changes are: