Skip to content

Add codegen updates #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 12, 2018
Merged

Add codegen updates #950

merged 31 commits into from
Jun 12, 2018

Conversation

lpatino10
Copy link
Contributor

This PR adds the newest generated code using the following commits:

  • API Definition: a3d247f2d250edf5b9743a41afcfebda52f66cf4
  • Codegen: 1b4341039c46d6794f65a12932698cb7aeb1c236

Most of the files changed are due to changes in comment formatting, so they can be skimmed.

The main code changes are:

  • Addition of Language Translator v3, with tests
  • Tests for RC instances in Language Translator and Visual Recognition

lpatino10 added 30 commits June 8, 2018 16:18
@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #950 into develop will decrease coverage by 26.26%.
The diff coverage is 52.65%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #950       +/-   ##
==============================================
- Coverage      65.31%   39.05%   -26.27%     
+ Complexity      2654     1470     -1184     
==============================================
  Files            564      580       +16     
  Lines          14243    14675      +432     
  Branches         809      840       +31     
==============================================
- Hits            9303     5731     -3572     
- Misses          4524     8610     +4086     
+ Partials         416      334       -82
Impacted Files Coverage Δ Complexity Δ
.../personality_insights/v3/model/ProfileOptions.java 100% <ø> (ø) 10 <0> (ø) ⬇️
...veloper_cloud/discovery/v1/model/QueryOptions.java 48.2% <ø> (-4.32%) 21 <0> (ø)
...oud/assistant/v1/model/UpdateWorkspaceOptions.java 87.35% <ø> (-5.75%) 10 <0> (-3)
..._cloud/assistant/v1/model/UpdateEntityOptions.java 75.92% <ø> (-24.08%) 6 <0> (-3)
..._cloud/speech_to_text/v1/model/RegisterStatus.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...conversation/v1/model/UpdateDialogNodeOptions.java 35.08% <ø> (-15.79%) 4 <0> (-16)
.../conversation/v1/model/UpdateWorkspaceOptions.java 87.35% <ø> (-5.75%) 10 <0> (-3)
...ech_to_text/v1/model/SpeechRecognitionResults.java 20% <ø> (-60%) 1 <0> (-3)
...understanding/v1/NaturalLanguageUnderstanding.java 56% <ø> (-16%) 8 <0> (-4)
...scovery/v1/model/ListCollectionFieldsResponse.java 50% <ø> (ø) 1 <0> (ø) ⬇️
... and 422 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d173cf6...fe99380. Read the comment docs.

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍looks good!
The only thing we might want to do is add iam authentication in these two readme files

https://github.com/watson-developer-cloud/java-sdk/blob/generated-updates/language-translator/README.md
https://github.com/watson-developer-cloud/java-sdk/blob/generated-updates/visual-recognition/README.md

@lpatino10
Copy link
Contributor Author

Good thinking. I'll add that now and merge.

@lpatino10 lpatino10 merged commit 4f98ad3 into develop Jun 12, 2018
@lpatino10 lpatino10 deleted the generated-updates branch June 12, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants