-
Notifications
You must be signed in to change notification settings - Fork 531
Update authentication section for clarity #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update intro to authentication - Move IAM to top of the stack of auth methods. Rename to just `IAM` - Update getting credentials section - Update Visual Recognition note - Change headings to sentence case - Update toc
Codecov Report
@@ Coverage Diff @@
## develop #954 +/- ##
==========================================
Coverage 39.05% 39.05%
Complexity 1470 1470
==========================================
Files 580 580
Lines 14675 14675
Branches 840 840
==========================================
Hits 5731 5731
Misses 8610 8610
Partials 334 334 Continue to review full report at Codecov.
|
What's your opinion on that? We don't offer an exposed method to refresh a user's token, so if their token did expire and they need to use a new one, they would basically need to set the I think that might be fine to leave out of explicit documentation but I could see the case for it. |
I don't have a strong opinion -- just noting that Mr. Kistler has it. We do have a link in the IAM section to how the process works. Because we're not supporting it, I think it makes more sense not to include it. |
@lopa, I updated the vcap info to point to our docs page. Does that work for the usage here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me 👍 Thanks for the updates!
Addresses changes requested from reviewers to make the authentication section clearer as we migrate services to IAM.
Summary
IAM
cc @mkistler @ehdsouza @anweshan @mediumTaj