Add data for newly captured voice models #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamoonraja
approved these changes
Nov 12, 2019
|
🎉 This PR is included in version 2.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's an issue where there are some new models which do not have associated sample audio or keywords. This is resulting in an error when users try to play the sample audio:
The models in question are:
es-AR_BroadbandModeles-AR_NarrowbandModeles-CL_BroadbandModeles-CL_NarrowbandModeles-CO_BroadbandModeles-CO_NarrowbandModeles-MX_BroadbandModeles-MX_NarrowbandModeles-PE_BroadbandModeles-PE_NarrowbandModelThis PR just points those models to the same sample files and keywords used by the
es-ES_BroadbandModelandes-ES_NarrowbandModelmodels for now, since the service team does not have real audio files ready for us to use.Demo: