Fix detect silence to work with smaller audio chunks #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediumTaj
reviewed
Nov 9, 2017
| @@ -177,7 +177,7 @@ private IEnumerator RecordingHandler() | |||
|
|
|||
| // Create AudioData and use the samples we just created | |||
| AudioData record = new AudioData(); | |||
| record.MaxLevel = Mathf.Max(samples); | |||
| record.MaxLevel = Mathf.Abs(Mathf.Max(samples)); | |||
There was a problem hiding this comment.
I think @cloudconstable suggested this will only get highest positive values and was worried if we have a sample that is completely negative. I don't know enough about audio to understand what the samples look like but heres a fix for that
record.MaxLevel = Mathf.Max(Mathf.Abs(Mathf.Min(samples)), Mathf.Max(samples));
There was a problem hiding this comment.
Of course! Good catch, I'll change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using smaller audio chunks it isn't safe to discard individual silent chunks. I propose tracking the duration of the silence, and only sending a stop once we reach a specified duration. For now I've chosen 1.0 second, but smaller values might work as well. All silent audio chunks will be discarded after this cutoff, until a non-silent chunk is encountered.