4310 gdpr #362
Merged
4310 gdpr #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mamoonraja This is ready for review when you get a chance! |
|
@kimberlysiva Tagging you in this PR as well to make sure nothing is broken because of changes in websocket-sharp! |
mamoonraja
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support for custom request headers and response headers in customData object.
The Unity SDK has always had an optional Dictionary<string, object> in the call for users to pass data and references around. We are leveraging this to send custom request headers. Custom response headers can be referenced in the callback via the same customData Dictionary.
For Websockets, I had to add some support for custom request headers and response headers. I forked the WebSocket-Sharp library here and added the DLL to the Unity SDK. I also changed the namespace from WebSocketSharp to UnitySDK.WebSocketSharp per #334.