Watson Unity SDK v2.3.0 #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release candidate revisions
…dme-vr revise vr endpoint, add a note on changing vr endpoints
… default to the non-iam visual recognition url
…isualrecognition-instances Support CF visual recognition instances
…delete-user-data-stt-tts Delete User Data in Speech to Text, Text to Speech and Visual Recognition
… - running tests locally for now
Merge in RC 2.3.0 changes
mamoonraja
reviewed
May 31, 2018
README.md
Outdated
| @@ -133,6 +135,21 @@ private void OnFail(RESTConnector.Error error, Dictionary<string, object> custom | |||
| } | |||
| ``` | |||
|
|
|||
| ### Authentication for Visual Recognition | |||
| Note there are different endpoints for authenticating a Visual Recognition instance depending on if you are authenticating using IAM or apikey. | |||
There was a problem hiding this comment.
Thinking out loud here, this can be confusing for VR actually because we used to have an api_key pre-IAM days and now we have apikey in credentials and apikey word can confuse users.
There was a problem hiding this comment.
Ah good catch! This needs to be removed since we handle this internally based on if they authenticate using apikey or tokenOptions
mamoonraja
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes IAM support in Visual Recognition. Also we use non region-specific URL for the IAM Url. Additionally, when authenticating Visual Recognition with an apikey rather than IAM, the default URL is set to the correct endpiont. Finally, I abstracted
DeleteUserData()for Speech to Text, Text to Speech and Visual Recognition.I also disabled the Travis Build and Test scripts until I can investigate Unity's issues running headless in Travis.