404 error in runtime #405
Merged
404 error in runtime #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks for the quick fix! Just FYI scripts inside an Editor folder are never included in a runtime build, so you don't really need to wrap the include in AotHelper, but it doesn't hurt anything :) |
mamoonraja
reviewed
Jun 25, 2018
| @@ -45,25 +43,25 @@ public class TestVisualRecognitionRC : UnitTest | |||
| private string _classifierID = ""; | |||
| private string _imageURL = "https://upload.wikimedia.org/wikipedia/commons/e/e9/Official_portrait_of_Barack_Obama.jpg"; | |||
|
|
|||
| #if DELETE_TRAINED_CLASSIFIER | |||
| #if TRAIN_DELETE_CLASSIFIER | |||
There was a problem hiding this comment.
Whats the reason behind using same variable for both train and delete?
There was a problem hiding this comment.
Because I don't want to pollute our instance of VisRec with classifiers. If I create a classifier I should delete it after I have tested it works.
mamoonraja
approved these changes
Jun 25, 2018
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses an error running UnityEditor code in outside of the Unity Editor (#404).
UnityEditor.GUID.Generate()was replaced withSystem.Guid.NewGuid()in ExampleDiscovery.cs and TestDiscovery.cs. OtherUnityEditorusing statements are now wrapped in an ifdef.Additionally,
VisualRecognitiontests were revised to consolidate create/delete classifier ifdefs and the ServiceExamples scene was revised to includeLanguageTranslatorV2andLanguageTranslatorV3.