Regenerate SDK with finalized SDK generator and write integration tests #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generator changes for null forms params, body param types
mediumTaj
changed the title
mamoonraja
approved these changes
Mar 18, 2019
| @@ -199,7 +199,7 @@ public class DigressOutSlotsValue | |||
| /// - It must be no longer than 1024 characters. | |||
| /// </summary> | |||
| [JsonProperty("dialog_node", NullValueHandling = NullValueHandling.Ignore)] | |||
| public string DialogNodeId { get; set; } | |||
| public string _DialogNode { get; set; } | |||
There was a problem hiding this comment.
a model cannot have a property with the same name (in this case DialogNode.DialogNode). That is reserved for the constructor. In the generator we append _ to this. When it was handwritten I just added Id
| @@ -17,22 +17,22 @@ | |||
|
|
|||
| using Newtonsoft.Json; | |||
|
|
|||
| namespace IBM.Watson.Discovery.V1.Model | |||
| namespace IBM.Watson.CompareComply.V1.Model | |||
There was a problem hiding this comment.
Maybe I am missing it but I am not seeing the Discovery Model, are we getting rid of it?
There was a problem hiding this comment.
Hmm the discovery models are there - this might be some weird renaming thing
| @@ -25,17 +25,17 @@ namespace IBM.Watson.Discovery.V1.Model | |||
| public class TrainingExample | |||
| { | |||
| /// <summary> | |||
| /// Gets or Sets DocumentId | |||
| /// The document ID associated with this training example. | |||
There was a problem hiding this comment.
Ignore the comment on CNC, here it is.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sorry for the huge PR....
This pull request addresses all generator issues in the Unity SDK and regenerates all services based on the latest openapi3 specs. Integration tests for all services were written using UnityTestRunner.