File type and Synthesized Filename parameters #539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mediumTaj
changed the title
Merged
mamoonraja
reviewed
Mar 21, 2019
Scripts/Services/NaturalLanguageUnderstanding/V1/Model/AnalysisResults.cs
Show resolved
Hide resolved
mamoonraja
approved these changes
Mar 26, 2019
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request changes
filetype fromFileStreamto the more genreicMemoryStreamso the user doesn't need to have data saved on disk. Since we now cannot get the filename from aMemoryStreamI implemented synthesized filenames that some of the other SDKs use. Previously the SDK took byte[].Additionally the SDK was regenerated using the latest OAS3 API definitions.