-
Notifications
You must be signed in to change notification settings - Fork 207
v3.0.0 #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-submodule Update submodule
…mit 0baaf120beb3852ab9557e700f5
…an null if no filename is requi
…-readme docs: Updated README.md
…rate-services Regenerate services
BREAKING CHANGE: Regenerated SDK
…de modules to gitignore
mamoonraja
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request releases Unity SDK v3.0.0. This release transitions the Unity SDK from handwritten to generated using IBM OpenAPI SDK Generator. The core of the SDK has been separated and included as a submodule dependency. This will allow other APIs to be generated for Unity in the future. We have removed the
customData
object in favor of other ways to pass in custom request headers and retrieve response headers and the raw json response. Part of that is removing the fail callback and having the callback return anIBMResponse
that includes the status code, headers, the result and the raw response. The callback also has anIBMError
that will be populated if the REST request fails. Changing the response, removing the fail callback and removing customData and generating the services results in breaking changes in each method signature.Additionally this release includes