Skip to content

v3.0.0 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 116 commits into from
Mar 28, 2019
Merged

v3.0.0 #548

merged 116 commits into from
Mar 28, 2019

Conversation

mediumTaj
Copy link
Contributor

Summary

This pull request releases Unity SDK v3.0.0. This release transitions the Unity SDK from handwritten to generated using IBM OpenAPI SDK Generator. The core of the SDK has been separated and included as a submodule dependency. This will allow other APIs to be generated for Unity in the future. We have removed the customData object in favor of other ways to pass in custom request headers and retrieve response headers and the raw json response. Part of that is removing the fail callback and having the callback return an IBMResponse that includes the status code, headers, the result and the raw response. The callback also has an IBMError that will be populated if the REST request fails. Changing the response, removing the fail callback and removing customData and generating the services results in breaking changes in each method signature.

Additionally this release includes

  • Dropping enum support in favor of constants
  • Removing the deprecated Conversation service
  • Transitioning to UnityTestRunner to run tests

@mediumTaj mediumTaj requested review from aairom and mamoonraja and removed request for aairom March 28, 2019 21:56
Copy link
Member

@mamoonraja mamoonraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@mediumTaj mediumTaj merged commit b8e5070 into master Mar 28, 2019
@mediumTaj mediumTaj deleted the v3.0.0 branch March 28, 2019 22:32
@mediumTaj
Copy link
Contributor Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants